Avoid creating transparent wrappers instead of peeling them off - #720
Merged
Conversation
Contributor
Author
|
@lzrd do you want me to close this, if you're not interested? |
jamesmunns
changed the base branch from
stoltz/fix-reflection-hubris-2615
to
master
August 4, 2026 15:25
jamesmunns
force-pushed
the
james/fix-reflection-hubris-2615
branch
from
August 4, 2026 15:28
47c3aed to
7e3933a
Compare
Contributor
|
Always nice to see more lines deleted than added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating wrappers and then peeling them off, we can instead just not create them in the first place.
Removed reflect tests since they now would require a HubrisArchive, but new core tests still pass the same.